[webkit-reviews] review granted: [Bug 80379] CSS3 calc: rewrite margin test to use getComputedStyle : [Attachment 130293] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 80379: CSS3 calc: rewrite margin test to use getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=80379

Attachment 130293: Patch
https://bugs.webkit.org/attachment.cgi?id=130293&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130293&action=review


> LayoutTests/css3/calc/margin-expected.txt:2
> +PASS getComputedStyle(document.getElementById("simple-all"),
null).marginLeft is "25px"
> +PASS getComputedStyle(document.getElementById("simple-all"), null).marginTop
is "25px"

nit: The result looks too busy. We can simplify it by adding functions.  e.g.
 computedMarginLeft("simple-all")
 computedMarginTop("simple-all")
 ...