[webkit-reviews] review granted: [Bug 80376] [V8][Performance] Optimize V8 bindings for HTMLElement.classList, Element.dataset and Node.attributes : [Attachment 130284] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 80376: [V8][Performance] Optimize V8 bindings for HTMLElement.classList,
Element.dataset and Node.attributes
https://bugs.webkit.org/show_bug.cgi?id=80376

Attachment 130284: Patch
https://bugs.webkit.org/attachment.cgi?id=130284&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130284&action=review


> Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp:95
> +	   static v8::Persistent<v8::String> hiddenReferenceName =
v8::Persistent<v8::String>::New(V8HiddenPropertyName::hiddenReferenceName("domS
tringMap"));

We should use DEFINE_STATIC_LOCAL.  Actually, consider using
V8HiddenPropertyName, which should solve this problem too.