[webkit-reviews] review granted: [Bug 80304] Web Inspector: move timeline panel overview mode toggle buttons to overview sidebar tree : [Attachment 130162] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 80304: Web Inspector: move timeline panel overview mode toggle buttons to
overview sidebar tree
https://bugs.webkit.org/show_bug.cgi?id=80304

Attachment 130162: Patch
https://bugs.webkit.org/attachment.cgi?id=130162&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130162&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:51
> +	   this._overviewModeSelector.addButton(WebInspector.UIString("Show
each event category as a horizontal strip in overview"),

Do not forget to update localizedStrings

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:157
> +	   if (!enabled === !this._verticalOverview)

if (enabled === this._verticalOverview) ?

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:173
> +	   if (this._currentMode ===
WebInspector.TimelineOverviewPane.Mode.Memory)

This looks ugly and the reason seems to be that you mix Horizontal / Vertical
modes with the Memory one.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:964
> +WebInspector.TimelineVerticalOverview.prototype.__proto__ =
WebInspector.View.prototype;

Do we need a 60 line class for a toggle button?

> Source/WebCore/inspector/front-end/TimelinePanel.js:386
> +	       this._repopulateRecords();

I don't think panel should be initiating repopulate. It sounds like overview
should call tell the presentation model to repopulate instead.

> Source/WebCore/inspector/front-end/timelinePanel.css:672
> +    background-image: -webkit-linear-gradient(top, rgb(80, 80, 80), rgb(140,
140, 140) 3px, rgb(160, 160, 160));

Gradients and text shadow look ugly on the screenshot. Could you remove those?