[webkit-reviews] review denied: [Bug 80373] Refactoring: Make InsertionPoint code clean. : [Attachment 130278] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 80373: Refactoring: Make InsertionPoint code clean.
https://bugs.webkit.org/show_bug.cgi?id=80373

Attachment 130278: Patch
https://bugs.webkit.org/attachment.cgi?id=130278&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130278&action=review


> Source/WebCore/ChangeLog:3
> +	   Refactoring: Make InsertionPoint code clean.

Could you explain the change more concretely?
What the following explanation says isn't cleanup apparently.

> Source/WebCore/ChangeLog:10
> +	   InsertionPoint used to attach fallback element before attaching
distributed elements.

fallback elements?

> Source/WebCore/ChangeLog:11
> +	   To be consistent with Element::attach behavior, attachign
distributed elements first is

s/attachign/attaching/

> Source/WebCore/html/shadow/InsertionPoint.cpp:52
> +	   distributeLightChildren(root->tree());

Could you reconsider the name? There is no term "light children" in the
standard.