[webkit-reviews] review granted: [Bug 80368] pinch-to-zoom and double-tap flicker when using the new scrolling model : [Attachment 130275] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 20:28:40 PST 2012


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 80368: pinch-to-zoom and double-tap flicker when using the new scrolling
model
https://bugs.webkit.org/show_bug.cgi?id=80368

Attachment 130275: Patch
https://bugs.webkit.org/attachment.cgi?id=130275&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130275&action=review


> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:141
> +static void dispatchBackToMainThread(uint64_t webPageID, uint64_t
callbackID)

Please consider renaming this to dispatchForceRepaintBackToMainThread or
something like that.  Or just add a fixme about adding barriers/fences.


More information about the webkit-reviews mailing list