[webkit-reviews] review granted: [Bug 80251] GraphicsContext3D.h should include RefCounted.h explicitly : [Attachment 130080] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 18:34:09 PST 2012


Rob Buis <rwlbuis at gmail.com> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 80251: GraphicsContext3D.h should include RefCounted.h explicitly
https://bugs.webkit.org/show_bug.cgi?id=80251

Attachment 130080: Patch
https://bugs.webkit.org/attachment.cgi?id=130080&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
The change is good since GraphicsContext3D does derive from RefCounted and
relying indirectly is not pretty. But please update the ChangeLog saying the
indirection goes through Animation.h and why it does not work for us.


More information about the webkit-reviews mailing list