[webkit-reviews] review granted: [Bug 78575] Web Inspector: Hide dock button when not allowed to dock : [Attachment 130237] [PATCH] Go through InspectorFrontendAPI - setDockingAvailability

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 17:11:37 PST 2012


Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 78575: Web Inspector: Hide dock button when not allowed to dock
https://bugs.webkit.org/show_bug.cgi?id=78575

Attachment 130237: [PATCH] Go through InspectorFrontendAPI -
setDockingAvailability
https://bugs.webkit.org/attachment.cgi?id=130237&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130237&action=review


> Source/WebCore/page/FrameView.cpp:2336
> +	       InspectorInstrumentation::didResizeMainFrame(m_frame.get());

This might not be the main frame. Do you need a check here?

if (Page* page = m_frame->page()) {
    if (page->mainFrame() == m_frame) { … }
}


More information about the webkit-reviews mailing list