[webkit-reviews] review granted: [Bug 80257] Lifecycle of InternalSettings should be simplified. : [Attachment 130229] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 80257: Lifecycle of InternalSettings should be simplified.
https://bugs.webkit.org/show_bug.cgi?id=80257

Attachment 130229: Patch
https://bugs.webkit.org/attachment.cgi?id=130229&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130229&action=review


rs=me

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=80257
> +	   Lifecycle of InternalSettings should be simplified.

The order is wrong :(

> Source/WebCore/testing/InternalSettings.cpp:94
> +    ,
m_passwordEchoDurationInSecondsBackup(settings()->passwordEchoDurationInSeconds
())
> +    , m_passwordEchoEnabledBackup(settings()->passwordEchoEnabled())

It's better to call these two variables m_originalPasswordEchoDurationInSeconds
and m_originalPasswordEchoEnabled to be consistent with similar variables in
WebKit.