[webkit-reviews] review denied: [Bug 79776] Parser: Inline ScopeNodeData into ScopeNode : [Attachment 129227] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 5 16:12:39 PST 2012
Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 79776: Parser: Inline ScopeNodeData into ScopeNode
https://bugs.webkit.org/show_bug.cgi?id=79776
Attachment 129227: Patch
https://bugs.webkit.org/attachment.cgi?id=129227&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129227&action=review
> Source/JavaScriptCore/parser/Nodes.cpp:91
> + , m_numConstants(numConstants)
> + , m_statements(children)
Seems problematic to leave these data members uninitialized in the other
ScopeNode constructor.
More information about the webkit-reviews
mailing list