[webkit-reviews] review granted: [Bug 80341] flakiness dashboard doesn't display baselines for virtual tests correctly : [Attachment 130216] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 80341: flakiness dashboard doesn't display baselines for virtual tests
correctly
https://bugs.webkit.org/show_bug.cgi?id=80341

Attachment 130216: Patch
https://bugs.webkit.org/attachment.cgi?id=130216&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130216&action=review


> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2205
> +    addExpectationItem(expectationsContainers, expectationsContainer, null,
test, TEST_URL_BASE_PATH);

May as well put an "if (!suite)" before this since this will always 404 if it
is a virtual test, right?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2219
> +    if (suite) {
> +	   loadBaselinesForTest(expectationsContainers, expectationsContainer,
baseTest(test, suite));
> +    }

Nit: WebKit style is to not put the curly braces.