[webkit-reviews] review denied: [Bug 79867] [BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp} : [Attachment 129652] patch v2

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 79867: [BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79867

Attachment 129652: patch v2
https://bugs.webkit.org/attachment.cgi?id=129652&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129652&action=review


Looks good, can be cleaned up some more.

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:54
> +#include "PlatformString.h"

Is PlatformString.h include really needed?

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:56
> +using namespace std;

Might not be needed if you use clampTo.

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:332
> +    float clampedOpacity = max(min(opacity, 1.0f), 0.0f);

better use clampTo from MathExtras.h to make clear what you are doing here.

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:356
> +	   m_layer->setNeedsDisplayInRect(rect);

You could look at putting some the one/two liners in the header, but only if
you do not need to add another include....

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:567
> +}

Above two functions look very similar, can we share code?

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:836
> +    m_contentsLayer->setPosition(FloatPoint(m_contentsRect.x(),
m_contentsRect.y()));

better use m_contentsLayer->setPosition(m_contentsRect.location());

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:853
> +	   m_contentsLayer->setAnchorPoint(FloatPoint(0, 0));

FloatPoint::zero