[webkit-reviews] review granted: [Bug 80285] TypedArray subarray call for subarray does not clamp the end index parameter properly : [Attachment 130143] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 12:00:25 PST 2012


Kenneth Russell <kbr at google.com> has granted Ulan Degenbaev
<ulan at chromium.org>'s request for review:
Bug 80285: TypedArray subarray call for subarray does not clamp the end index
parameter properly
https://bugs.webkit.org/show_bug.cgi?id=80285

Attachment 130143: Patch
https://bugs.webkit.org/attachment.cgi?id=130143&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130143&action=review


Thanks for fixing this. Looks fine aside from the ChangeLog; could you please
fix and re-upload?

> ChangeLog:10
> +	   * Source/JavaScriptCore/wtf/ArrayBufferView.h:

This is the wrong ChangeLog to modify. You probably have an incomplete WebKit
checkout; see http://dev.chromium.org/ for instructions on how to use a full
WebKit checkout within your Chromium tree. You should see edits in
Source/JavaScriptCore/ChangeLog and LayoutTests/ChangeLog.


More information about the webkit-reviews mailing list