[webkit-reviews] review granted: [Bug 80196] Replace remaining uses of x, y and width, height pairs with Point and Size : [Attachment 129970] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 5 10:42:17 PST 2012
Julien Chaffraix <jchaffraix at webkit.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 80196: Replace remaining uses of x, y and width, height pairs with Point
and Size
https://bugs.webkit.org/show_bug.cgi?id=80196
Attachment 129970: Patch
https://bugs.webkit.org/attachment.cgi?id=129970&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
Nit: In HTMLCanvasElement, this line could welcome the same change: FloatRect r
= mapRect(rect, FloatRect(0, 0, size().width(), size().height()), destRect);
Also there are other places where we could use the same pattern (like
IntRect(0, 0, someComputedHeight, someComputedWidth) in the rendering code) so
it seems as if the title is misleading IMHO.
More information about the webkit-reviews
mailing list