[webkit-reviews] review denied: [Bug 80119] [EFL] Add OwnPtr specialization for Ecore_Timer : [Attachment 130066] Patch

[bugzilla-daemon at webkit.org]

Raphael Kubo da Costa <kubo at profusion.mobi> has denied YoungTaeck Song
<youngtaeck.song at samsung.com>'s request for review:
Bug 80119: [EFL] Add OwnPtr specialization for Ecore_Timer
https://bugs.webkit.org/show_bug.cgi?id=80119

Attachment 130066: Patch
https://bugs.webkit.org/attachment.cgi?id=130066&action=review

------- Additional Comments from Raphael Kubo da Costa <kubo at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=130066&action=review


> Source/WebCore/platform/efl/SharedTimerEfl.cpp:41
> -static Ecore_Timer *_sharedTimer = 0;
> +static OwnPtr<Ecore_Timer> sharedTimer;

Declaring a static object like this makes the code prone to all sorts of
problems, since you can't guarantee when this object will be initialized.
Either keep the old version, or use the DEFINE_STATIC_LOCAL macro to make sure
the object is created on first use.