[webkit-reviews] review denied: [Bug 80020] [Crash] Adding <content> into a ShadowRoot causes crash. : [Attachment 130085] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 80020: [Crash] Adding <content> into a ShadowRoot causes crash.
https://bugs.webkit.org/show_bug.cgi?id=80020

Attachment 130085: Patch
https://bugs.webkit.org/attachment.cgi?id=130085&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130085&action=review


Introducing two different paths for attaching seems like a bad idea. Can you
help me understand why you need this?

> Source/WebCore/ChangeLog:8
> +	   When layouting a shadow tree, we're currently assuming that the
whole tree is re-created.

layouting -> laying out.

> Source/WebCore/ChangeLog:9
> +	   However, when appending a child, subtree attaching occurs.

And why is that bad?

> Source/WebCore/dom/ShadowTree.cpp:41
>  ShadowTree::ShadowTree()

Also: why is this called a Tree? It's really a ShadowTreeStack, isn't it?