[webkit-reviews] review granted: [Bug 80286] Web Inspector: stop using RawSourceCode in BreakpointManager. : [Attachment 130153] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 5 09:36:37 PST 2012
Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 80286: Web Inspector: stop using RawSourceCode in BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=80286
Attachment 130153: Patch
https://bugs.webkit.org/attachment.cgi?id=130153&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130153&action=review
> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:45
> + this._breakpointManager = new
WebInspector.BreakpointManager(WebInspector.settings.breakpoints,
One line?
> Source/WebCore/inspector/front-end/ScriptMapping.js:48
> + rawLocationToUILocation: function(rawLocation)
rawLocationToUILocation: function(rawLocation) { },
> Source/WebCore/inspector/front-end/ScriptMapping.js:58
> + uiLocationToRawLocation: function(uiSourceCode, lineNumber,
columnNumber)
ditto
> Source/WebCore/inspector/front-end/ScriptMapping.js:68
> + {
ditto
> Source/WebCore/inspector/front-end/ScriptMapping.js:75
> + {
ditto
More information about the webkit-reviews
mailing list