[webkit-reviews] review denied: [Bug 80286] Web Inspector: stop using RawSourceCode in BreakpointManager. : [Attachment 130135] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 80286: Web Inspector: stop using RawSourceCode in BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=80286

Attachment 130135: Patch
https://bugs.webkit.org/attachment.cgi?id=130135&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130135&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:37
> + * @param {WebInspector.DebuggerPresentationModel} sourceMapping

Maybe scriptMapping?
Could you please add an interface (ScriptMapping?) and implement it in
DebuggerPresentationModel?

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:45
> +    this._breakpointManager = new
WebInspector.BreakpointManager(WebInspector.settings.breakpoints,

I think one long line would be better.