[webkit-reviews] review denied: [Bug 80225] Web Inspector: CSS inactive property check should account for vendor prefixes : [Attachment 130121] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 80225: Web Inspector: CSS inactive property check should account for vendor
prefixes
https://bugs.webkit.org/show_bug.cgi?id=80225

Attachment 130121: Patch
https://bugs.webkit.org/attachment.cgi?id=130121&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130121&action=review


> Source/WebCore/inspector/InspectorStyleSheet.cpp:484
> +		   CSSPropertyID propertyId =
static_cast<CSSPropertyID>(cssPropertyID(name));

This does not seem to cover the computed style trace.

> LayoutTests/inspector/elements/elements-panel-styles-expected.txt:13
> +    .foo, .foo::before - blue elements-panel-styles.css:25

Please prefer adding new tests for new features / regressions.