[webkit-reviews] review granted: [Bug 80121] [BlackBerry] Upstream Texture and TextureCache : [Attachment 130084] updated patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 80121: [BlackBerry] Upstream Texture and TextureCache
https://bugs.webkit.org/show_bug.cgi?id=80121

Attachment 130084: updated patch
https://bugs.webkit.org/attachment.cgi?id=130084&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130084&action=review


Looks good, please have a look at my remarks before landing, maybe Leo can set
cq+ once that is done.

> Source/WebCore/platform/graphics/blackberry/Texture.cpp:83
> +    bool subImage = (tile.size() == m_size);

Could just be bool subImage = tile.size() == m_size;

> Source/WebCore/platform/graphics/blackberry/Texture.cpp:91
> +    IntSize yeOldeSize = size;

yeOldeSize sounds a bit silly, can just be oldSize.

> Source/WebCore/platform/graphics/blackberry/Texture.h:24
> +#include "IntRect.h"

Looks like it can be a forward class reference.

>
Source/WebCore/platform/graphics/blackberry/TextureCacheCompositingThread.h:29
> +#include <memory>

Nothing in that file seems needed here?