[webkit-reviews] review granted: [Bug 80277] [Qt] Create ews to build webkit2 : [Attachment 130113] create wk2 ews
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 5 06:54:56 PST 2012
Csaba Osztrogonac <ossy at webkit.org> has granted Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 80277: [Qt] Create ews to build webkit2
https://bugs.webkit.org/show_bug.cgi?id=80277
Attachment 130113: create wk2 ews
https://bugs.webkit.org/attachment.cgi?id=130113&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130113&action=review
LGTM, r=me with the following changes.
> Tools/ChangeLog:3
> + [Qt] Create ews to build webkit2
ews -> EWS
webkit2 -> WebKit2
> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:163
> +class QtWk2EWS(AbstractEarlyWarningSystem):
QtWk2EWS -> QtWK2EWS
> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:86
> + self._test_builder_ews(QtWk2EWS())
QtWk2EWS -> QtWK2EWS
More information about the webkit-reviews
mailing list