[webkit-reviews] review granted: [Bug 80127] Web Inspector: add timeline instrumentation for frame events : [Attachment 129932] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 80127: Web Inspector: add timeline instrumentation for frame events
https://bugs.webkit.org/show_bug.cgi?id=80127

Attachment 129932: Patch
https://bugs.webkit.org/attachment.cgi?id=129932&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129932&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:283
> +	   return this._windowEndTime ||
this._presentationModel.maximumRecordTime();

!!this._windowEndTime ?

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:809
> +	   var scale = (this.element.clientHeight - 4) / boundarySpan;

Please use const paddingTop = 4;