[webkit-reviews] review requested: [Bug 61338] Element not fully repainted after application and removal of transform : [Attachment 130065] patch to repaint the element when its transform property is removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 00:25:35 PST 2012


Kishore Bolisetty <kbolisetty at innominds.com> has asked	for review:
Bug 61338: Element not fully repainted after application and removal of
transform
https://bugs.webkit.org/show_bug.cgi?id=61338

Attachment 130065: patch to repaint the element when its transform property is
removed
https://bugs.webkit.org/attachment.cgi?id=130065&action=review

------- Additional Comments from Kishore Bolisetty <kbolisetty at innominds.com>
Modified patch based on review comments.

Hi Julien/Simon,
Unfortunately I could not use "positioned" style for this test due to following
reasons.
1. z-index of an element can not be auto when the transform property is ON for
an element.
2. z-index of an element is usually auto in normal scenarios like no transform.

As you know z-index effect is considered only for positioned elements,
the z-index auto value is being used in StyleDiff for a positioned element and
on that basis StyleDiff returned can be StyleDifferenceRepaintLayer.
thus making the issue not reproducible when "positioned" style is applied.
Hence i could not make a test case such that Green div element getting placed
on Red div element.

Except for this exception,I tried to incorporate all your suggestions turning
it to ref test.
Thanks for your review comments, they are quite helpful in resubmitting the
patch.


More information about the webkit-reviews mailing list