[webkit-reviews] review denied: [Bug 80237] Internally used HTMLContentElement classes should have correct wrapper. : [Attachment 130060] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Hajime Morrita
<morrita at google.com>'s request for review:
Bug 80237: Internally used HTMLContentElement classes should have correct
wrapper.
https://bugs.webkit.org/show_bug.cgi?id=80237

Attachment 130060: Patch
https://bugs.webkit.org/attachment.cgi?id=130060&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130060&action=review


almost ok.  I have some minor comments.

> Source/WebCore/dom/make_names.pl:329
>	   my $interfaceName = $enabledTags{$tagName}{interfaceName};
> -
>	   if ($enabledTags{$tagName}{mapToTagName}) {

Removing unrelated line isn't good.

> LayoutTests/fast/dom/shadow/content-element-user-agent-shadow-expected.txt:3
> +PASS parsedElementShouldBeUnknown.tagName is expectedTagName
> +PASS 0 <
parsedElementShouldBeUnknown.constructor.toString().indexOf('HTMLUnknownElement
') is true
> +PASS contentInuserAgentShadow.tagName is expectedTagName

Showing 'expectedTagName' isn't good for readability.  Please show
WEBKITSHADOWCONTENT.