[webkit-reviews] review granted: [Bug 79600] Implement the basis of KURLWTFURL : [Attachment 130010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 3 17:05:47 PST 2012


Adam Barth <abarth at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 79600: Implement the basis of KURLWTFURL
https://bugs.webkit.org/show_bug.cgi?id=79600

Attachment 130010: Patch
https://bugs.webkit.org/attachment.cgi?id=130010&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130010&action=review


> Source/WebCore/platform/KURLWTFURL.cpp:103
> +	   DEFINE_STATIC_LOCAL(const String, nullString, ());

This shouldn't really be needed.  A null string is just a value type anyway.

> Source/WebCore/platform/KURLWTFURL.cpp:219
> +    return WebCore::protocolIs(protocol(), testProtocol);

Part of the point of this function is to avoid the malloc.  This implementation
keeps the malloc...


More information about the webkit-reviews mailing list