[webkit-reviews] review granted: [Bug 80019] Implement Speech JavaScript API : [Attachment 129689] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Hans Wennborg <hans at chromium.org>'s
request for review:
Bug 80019: Implement Speech JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=80019

Attachment 129689: Patch
https://bugs.webkit.org/attachment.cgi?id=129689&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129689&action=review


> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:157
> +#if ENABLE(SCRIPTED_SPEECH)
> +    static void setScriptedSpeechEnabled(bool isEnabled) {
isScriptedSpeechEnabled = isEnabled; }
> +    static bool scriptedSpeechEnabled() { return isScriptedSpeechEnabled; }
> +    static bool webkitSpeechRecognitionEnabled() { return
isScriptedSpeechEnabled; }
> +    static bool webkitSpeechRecognitionErrorEnabled() { return
isScriptedSpeechEnabled; }
> +    static bool webkitSpeechGrammarEnabled() { return
isScriptedSpeechEnabled; }
> +    static bool webkitSpeechGrammarListEnabled() { return
isScriptedSpeechEnabled; }
> +#endif

This change is slightly ahead of what you need in this patch.