[webkit-reviews] review denied: [Bug 80211] [EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate : [Attachment 129999] proposed patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 80211: [EFL] Evas_GL initialization and destruction in
GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=80211

Attachment 129999: proposed patch
https://bugs.webkit.org/attachment.cgi?id=129999&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129999&action=review


> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:58
> +    if (m_evasGL) {

Style: early-return here.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:87
> +    m_context = evas_gl_context_create(m_evasGL, 0);

What does 0 stand for? comment.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:102
> +    int x = 0, y = 0, width = 1, height = 1;

separate lines.