[webkit-reviews] review granted: [Bug 80188] Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round : [Attachment 129951] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 80188: Implement NamedNodeMap::setNamedItem() in terms of
Element::setAttributeNode() instead of the other way round
https://bugs.webkit.org/show_bug.cgi?id=80188

Attachment 129951: Patch
https://bugs.webkit.org/attachment.cgi?id=129951&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129951&action=review


> Source/WebCore/dom/NamedNodeMap.cpp:108
> +    Attr* attr = static_cast<Attr*>(node);
> +    return m_element->setAttributeNode(attr, ec);

Do we really need a local variable?