[webkit-reviews] review granted: [Bug 80180] links for virtual tests are broken in the flakiness dashboard : [Attachment 129936] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 80180: links for virtual tests are broken in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80180

Attachment 129936: Patch
https://bugs.webkit.org/attachment.cgi?id=129936&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Please do add a test. The test suite for this code is pretty...bare, but
testing this specific thing should be easy enough. The tests are in
flakiness_dashboard_tests.js, you run them in the browser by loading
flakiness_dashboard#useTestData=true off your local disk. It's wonky, but good
enough for now. :)

Did you test loading the expected results for the test, e.g. a page like
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpecta
tions=true&tests=fast%2Fjs%2Fnavigator-language.html? The test itself should be
one of the frames. Also, we show all the expected results in the fallback
order. How does the fallback order for virtual tests work? You probably need to
update that code as well.