[webkit-reviews] review granted: [Bug 80169] Create a method in Element to compare attributes with other Element : [Attachment 129918] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 80169: Create a method in Element to compare attributes with other Element
https://bugs.webkit.org/show_bug.cgi?id=80169

Attachment 129918: Patch
https://bugs.webkit.org/attachment.cgi?id=129918&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129918&action=review


> Source/WebCore/dom/Node.cpp:1775
> +    if (isElementNode() &&
!toElement(this)->hasEquivalentAttributes(toElement(other)))

Maybe we should an inline helper that takes Node* and returns false when its'
not an element? That'll avoid having to cast nodes.

> Source/WebCore/editing/htmlediting.cpp:1161
> +    if (!firstElement->tagQName().matches(secondElement->tagQName()))

Can't we do firstElement->hasTagQName(secondElement->tagQName()) ? Maybe this
is slower?