[webkit-reviews] review denied: [Bug 79947] [V8] Bindings for node always check if they are a Document. : [Attachment 129727] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 79947: [V8] Bindings for node always check if they are a Document.
https://bugs.webkit.org/show_bug.cgi?id=79947

Attachment 129727: Patch
https://bugs.webkit.org/attachment.cgi?id=129727&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129727&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3038
> +    if (IsNodeSubType($dataNode) && $interfaceName ne "DocumentType") {
> +	   $proxyInit = "V8Proxy::retrieve(impl->document()->frame())";
> +    } else {
> +	   $proxyInit = "0";

Why is $proxyInit always zero when $interfaceName ne "DocumentType" ?  I would
have expected the DocumentType case to need a null-check on impl->document(). 
Presumably when impl->document() is non-null, the "DocumentType" case should
work the same as the other nodes.