[webkit-reviews] review granted: [Bug 74409] [GTK] plugins/netscape-plugin-page-cache-works.html fails : [Attachment 129894] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 74409: [GTK] plugins/netscape-plugin-page-cache-works.html fails
https://bugs.webkit.org/show_bug.cgi?id=74409

Attachment 129894: Patch
https://bugs.webkit.org/attachment.cgi?id=129894&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129894&action=review


> Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:841
>	   return;
> +    } else if (g_str_equal(originalName.get(),
"WebKitPageCacheSupportsPluginsPreferenceKey")) {
> +	  
DumpRenderTreeSupportGtk::setPageCacheSupportsPlugins(webkit_web_frame_get_web_
view(mainFrame), !g_ascii_strcasecmp(valueAsString.get(), "true") ||
!g_ascii_strcasecmp(valueAsString.get(), "1"));
> +	   return;

Please turn !g_ascii_strcasecmp(valueAsString.get(), "true") ||
!g_ascii_strcasecmp(valueAsString.get() into a helper function, now that it's
repeated three times.