[webkit-reviews] review granted: [Bug 80143] Web Inspector: update execution line using LiveLocation. : [Attachment 129871] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 80143: Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143

Attachment 129871: Patch
https://bugs.webkit.org/attachment.cgi?id=129871&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129871&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:547
> +	   this._exectionLineLiveLocation.dispose();

_execUtionLineLiveLocation
typo ^

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:548
> +	   this._exectionLineLiveLocation = null;

This logic should be moved to selectedCallFrame setter, so that you don't need
to call dispose twice.