[webkit-reviews] review denied: [Bug 80097] [Forms] Make order of attribute/method in HTMLSelectElement.idl as same as specification : [Attachment 129816] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 80097: [Forms] Make order of attribute/method in HTMLSelectElement.idl as
same as specification
https://bugs.webkit.org/show_bug.cgi?id=80097

Attachment 129816: Patch 1
https://bugs.webkit.org/attachment.cgi?id=129816&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129816&action=review


>> Source/WebCore/html/HTMLSelectElement.idl:-31
>> -	    // Modified in DOM Level 2:
> 
> Why did you remove this comment?

This comment explains why we have #if defined(LANGUAGE_OBJECTIVE_C)...
So, we shouldn't remove it.

>> Source/WebCore/html/HTMLSelectElement.idl:-45
>> -	    // Modified in DOM Level 2:
> 
> Ditto

This comment looks non-sense.  ok to remove it.

>> Source/WebCore/html/HTMLSelectElement.idl:-67
>> -	    // "The contained options can be directly accessed through the
select element as a collection."
> 
> Ditto

It's ok to remove this comment because the WHATWG spec has them.