[webkit-reviews] review denied: [Bug 80098] DFGCodeBlocks should not trace CodeBlocks that are also going to be traced by virtue of being in the transitive closure : [Attachment 129815] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 80098: DFGCodeBlocks should not trace CodeBlocks that are also going to be
traced by virtue of being in the transitive closure
https://bugs.webkit.org/show_bug.cgi?id=80098

Attachment 129815: the patch
https://bugs.webkit.org/attachment.cgi?id=129815&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I just realized that this fix is inadequate. The reason why we were scanning
the CodeBlocks even if they were not jettisoned is that they might become
jettisoned later in the GC!

The correct fix is to have a separate mechanism for ensuring that a CodeBlock
is only scanned once.  I will work on this...