[webkit-reviews] review requested: [Bug 79927] [chromium] Add clipping to scissor rect to CCOcclusionTracker : [Attachment 129810] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 79927: [chromium] Add clipping to scissor rect to CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=79927

Attachment 129810: Patch
https://bugs.webkit.org/attachment.cgi?id=129810&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Yak punted! There's lots of things I want to address wrt to RenderSurface, and
this is another.

No MaybeRects needed, success. Thanks for that.

Realized the RenderSurface::clipRect() is in the target's coord space, not the
surface's own. Reworked how scissor
is computed for layers and surfaces accordingly. This made me use
RenderSurface::damageContentRect() instead of
RenderSurface::scissorRect() because the surface can't compute its own scissor
without knowing the damage in its target.
The damageContentRect() is combined with the current layer/surface's clip in
CCOcclusionTracker to determine the
appropriate scissor rect.