[webkit-reviews] review requested: [Bug 62698] Support for Battery Status API : [Attachment 129806] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 21:37:21 PST 2012


Kihong Kwon <kihong.kwon at samsung.com> has asked  for review:
Bug 62698: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Attachment 129806: Patch.
https://bugs.webkit.org/attachment.cgi?id=129806&action=review

------- Additional Comments from Kihong Kwon <kihong.kwon at samsung.com>
I updated the test patch yesterday - sorry about the delay in doing so.
I would need your comments for the issue mentioned below.

Battery Status API needs to be added under the Navigator class, but there is
not any event handling logic there. Therefore, because I have no other choice,
I have implemented the necessary event handling logic in the BatteryManager. I,
however, think it may not look good to add the event listener in the Batter
Status API itself.

IMHO, the Navigator class would need some sort of event listener handling logic
similar to DOMWindow. I would like to have your comments how you think this.

Thank you.


More information about the webkit-reviews mailing list