[webkit-reviews] review granted: [Bug 80090] Move the 'overflow' event dispatching logic out of RenderLayer : [Attachment 129801] Proposed refactoring: add an RAII class to handle dispatching events.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 1 20:44:47 PST 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 80090: Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Attachment 129801: Proposed refactoring: add an RAII class to handle
dispatching events.
https://bugs.webkit.org/attachment.cgi?id=129801&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129801&action=review
> Source/WebCore/rendering/RenderBlock.cpp:126
> + void computeOverflowStatus(bool& hasHorizontalLayoutOverflow, bool&
hasVerticalLayoutOverflow)
> + {
> + hasHorizontalLayoutOverflow =
m_block->hasHorizontalLayoutOverflow();
> + hasVerticalLayoutOverflow = m_block->hasVerticalLayoutOverflow();
> + }
Having this method seems like overkill, since it just retrieves two bools.
More information about the webkit-reviews
mailing list