[webkit-reviews] review granted: [Bug 80083] nrwt: virtual tests aren't being run : [Attachment 129792] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 80083: nrwt: virtual tests aren't being run
https://bugs.webkit.org/show_bug.cgi?id=80083

Attachment 129792: Patch
https://bugs.webkit.org/attachment.cgi?id=129792&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129792&action=review


> Tools/Scripts/webkitpy/layout_tests/port/base.py:1086
> +		   for test in suite.tests:
> +		       if any(test.startswith(p) for p in paths):
> +			   virtual_tests.add(test)
> +	       else:
> +		   virtual_tests.update(set(suite.tests.keys()))

I suspect this whole block could be written shorter with comprehesions or a
filter statement.