[webkit-reviews] review requested: [Bug 80061] Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper : [Attachment 129763] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 80061: Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper
https://bugs.webkit.org/show_bug.cgi?id=80061

Attachment 129763: Patch
https://bugs.webkit.org/attachment.cgi?id=129763&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129763&action=review


> Source/WebCore/Modules/indexeddb/PageGroupIndexedDatabase.cpp:44
> +PageGroupIndexedDatabase* PageGroupIndexedDatabase::from(PageGroup& group)

PassOwnPtr?

> Source/WebCore/Modules/indexeddb/PageGroupIndexedDatabase.cpp:47
> +    DEFINE_STATIC_LOCAL(AtomicString, name, ("PageGroupIndexedDatabase"));
> +    PageGroupIndexedDatabase* supplement =
static_cast<PageGroupIndexedDatabase*>(Supplement<PageGroup>::from(&group,
name));

One wonders why we don't just make these hashes static on the Suplement
implementation, instead of keyed off of an AtomicString.

> Source/WebCore/Modules/indexeddb/PageGroupIndexedDatabase.h:41
> +    static PageGroupIndexedDatabase* from(PageGroup&);

I'm surprised I didn't rag on you about using smart pointers for these from()
functions earlier.  Seems leaky w/o them...