[webkit-reviews] review granted: [Bug 80061] Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper : [Attachment 129761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 15:42:39 PST 2012


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 80061: Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper
https://bugs.webkit.org/show_bug.cgi?id=80061

Attachment 129761: Patch
https://bugs.webkit.org/attachment.cgi?id=129761&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129761&action=review


This modules thing really has worked out well, it seems.  So much less crap in
these core classes.

> Source/WebCore/page/PageGroup.h:46
> +    class PageGroup : public Supplementable<PageGroup> {

Remind me what (if any) over head Suplementable adds to this object?  No
storage, correct?


More information about the webkit-reviews mailing list