[webkit-reviews] review denied: [Bug 33593] getComputedStyle gives incorrect information for 'height' property : [Attachment 129719] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 33593: getComputedStyle gives incorrect information for 'height' property
https://bugs.webkit.org/show_bug.cgi?id=33593

Attachment 129719: Patch
https://bugs.webkit.org/attachment.cgi?id=129719&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129719&action=review


> Source/WebCore/editing/DeleteSelectionCommand.cpp:366
> +	   if (r && r->isTableCell() &&
toRenderTableCell(r)->contentHeight(true) <= 0) {

Enums are alwasy more clear than booleans.

> Source/WebCore/rendering/RenderBox.h:181
> +    LayoutUnit contentWidth(bool includeIntrinsicPadding = false) const {
return clientWidth() - paddingLeft(includeIntrinsicPadding) -
paddingRight(includeIntrinsicPadding); }

Please make this an Enum if you're going to go this route.

enum PaddingOptions { IncludeIntrinsicPadding, ExcludeIntrinsicPadding }