[webkit-reviews] review granted: [Bug 73164] unicode-bidi should support isolate override and override isolate : [Attachment 116789] Made bidi-override-isolate.html a reftest

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 73164: unicode-bidi should support isolate override and override isolate
https://bugs.webkit.org/show_bug.cgi?id=73164

Attachment 116789: Made bidi-override-isolate.html a reftest
https://bugs.webkit.org/attachment.cgi?id=116789&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116789&action=review


I don't really like this spec change, but the implementation looks OK.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:997
> +	   {
> +	       RefPtr<CSSValueList> list =
CSSValueList::createSpaceSeparated();
> +	      
list->append(primitiveValueCache->createIdentifierValue(CSSValueBidiOverride));

> +	      
list->append(primitiveValueCache->createIdentifierValue(CSSValueWebkitIsolate))
;
> +	       return list;
> +	   }

I don' think this is quite the right indent.  I think the { themselves do not
get indented.