[webkit-reviews] review denied: [Bug 65168] Use AtomicString in Document::documentNamedItems and Document::windowNamedItems : [Attachment 101983] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 13:56:54 PST 2012


Eric Seidel <eric at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 65168: Use AtomicString in Document::documentNamedItems and
Document::windowNamedItems
https://bugs.webkit.org/show_bug.cgi?id=65168

Attachment 101983: Patch
https://bugs.webkit.org/attachment.cgi?id=101983&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101983&action=review


>> Source/WebCore/dom/Document.cpp:4152
>>	return HTMLNameCollection::create(this, WindowNamedItems, name);
> 
> But HTMLNameCollection::create takes const String!

That doesn't make the change completely invalid, but w/o some sort of
microbenchmark to demonstrate that this is a win, this isn't worth doing w/o
the AtomicStirng being kept around.


More information about the webkit-reviews mailing list