[webkit-reviews] review denied: [Bug 79678] SVG transform-origin presentation attribute : [Attachment 129716] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied  review:
Bug 79678: SVG transform-origin presentation attribute
https://bugs.webkit.org/show_bug.cgi?id=79678

Attachment 129716: Patch
https://bugs.webkit.org/attachment.cgi?id=129716&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129716&action=review


Sorry, I have to r- this patch.

> Source/WebCore/svg/SVGStyledElement.cpp:64
> +    if (!propertyId && attrName == transform_originAttr)

Hm, seems high impact for this special case.
Why not change the singe call-site that calls mapAttributetoCSSProperty with
transform_originAttr??
Add a new mapWebKitTransformOriginAttrToCSSProperty(..) method.

Also are you sure we want to add this unprefixed for SVG? Is there agreement
that a transform-origin pres attr should exist? Where is it specified?