[webkit-reviews] review granted: [Bug 50547] Custom scrollbars do not support transparency : [Attachment 129673] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 13:24:46 PST 2012


James Robinson <jamesr at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 50547: Custom scrollbars do not support transparency
https://bugs.webkit.org/show_bug.cgi?id=50547

Attachment 129673: Patch
https://bugs.webkit.org/attachment.cgi?id=129673&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129673&action=review


This is only for the root scrollbars, right? Subframe scrollbars should be
fine.

I think background color is the right choice here.

> LayoutTests/fast/frames/transparent-scrollbar.html:31
> +	       window.layoutTestController.display();

i think this would be better as a dumpAsText(true) test to retain the pixel
output but suppress the render tree. the render tree isn't helpful


More information about the webkit-reviews mailing list