[webkit-reviews] review granted: [Bug 80034] REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in WebCore::localizedString() when using a WebKit nightly build : [Attachment 129721] Null-check the return value of CFBundleGetBundleWithIdentifier()

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted mitz at webkit.org's request
for review:
Bug 80034: REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in
WebCore::localizedString() when using a WebKit nightly build
https://bugs.webkit.org/show_bug.cgi?id=80034

Attachment 129721: Null-check the return value of
CFBundleGetBundleWithIdentifier()
https://bugs.webkit.org/attachment.cgi?id=129721&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129721&action=review


> Source/WebCore/platform/mac/LocalizedStringsMac.cpp:55
> +    else
> +	   result = notFound;
>  
>      ASSERT_WITH_MESSAGE(result.get() != notFound, "could not find
localizable string %s in bundle", key);

You are gonna hit the assert every time. Better move the assert in the if()