[webkit-reviews] review granted: [Bug 79723] [chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe : [Attachment 129147] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 79723: [chromium] Rename LayerChromium::name to debugName to be more
consistent with other debug properties, make threadsafe
https://bugs.webkit.org/show_bug.cgi?id=79723

Attachment 129147: Patch
https://bugs.webkit.org/attachment.cgi?id=129147&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129147&action=review


Yay, thread safety.

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:-492
> -    EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(0, testLayer->setName("Test
Layer"));

nit: Can you move this line to the section that makes sure it does call
needsCommit rather than just removing it?