[webkit-reviews] review granted: [Bug 79078] Add HTML Popup API to ChromeClient : [Attachment 129643] Patch 4

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 79078: Add HTML Popup API to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=79078

Attachment 129643: Patch 4
https://bugs.webkit.org/attachment.cgi?id=129643&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129643&action=review


> Source/WebCore/page/PagePopupClient.h:50
> +    virtual String htmlSource() = 0;

This seems really hacky. After building this string by combining embedded
resources, you will still need to use a loader to get this into the popup.
Would it be better to implement a new kind of loader that just allows pulling
stuff from resources? Well, that may have its own problems, such as
performance. We don't want the popup to take forever to load...