[webkit-reviews] review denied: [Bug 62698] Support for Battery Status API : [Attachment 129681] Patch.

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 62698: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Attachment 129681: Patch.
https://bugs.webkit.org/attachment.cgi?id=129681&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129681&action=review


> Tools/Scripts/build-webkit:320
> -	 define => "ENABLE_SVG", default => 1, value => \$svgSupport },
> +	 define => "ENABLE_SVG", default => 0, value => \$svgSupport },

You should not change these defaults, specially not in an unrelated patch.

> Tools/Scripts/build-webkit:326
> -	 define => "ENABLE_SVG_FONTS", default => 1, value => \$svgFontsSupport
},
> +	 define => "ENABLE_SVG_FONTS", default => 0, value => \$svgFontsSupport
},

Ditto.

> Tools/Scripts/build-webkit:344
> -	 define => "ENABLE_VIDEO_TRACK", default => (isAppleWebKit() ||
isGtk()), value => \$videoTrackSupport },
> +	 define => "ENABLE_VIDEO_TRACK", default => (isAppleWebKit() || isGtk()
|| isEfl()), value => \$videoTrackSupport },

Unrelated, better have it in a separate patch.