[webkit-reviews] review requested: [Bug 74706] [Qt] QtWebKit disregards LocalContentCanAccessFileUrls setting : [Attachment 129708] Proposed patch + layout test + Qt auto test (v2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 08:24:59 PST 2012


Bruno Abinader <bruno.de_oliveira at basyskom.de> has asked  for review:
Bug 74706: [Qt] QtWebKit disregards LocalContentCanAccessFileUrls setting
https://bugs.webkit.org/show_bug.cgi?id=74706

Attachment 129708: Proposed patch + layout test + Qt auto test (v2)
https://bugs.webkit.org/attachment.cgi?id=129708&action=review

------- Additional Comments from Bruno Abinader <bruno.de_oliveira at basyskom.de>
Updated patch simplifying layout test code (using HTML5 DOCTYPE and removing
unnecessary JavaScript functions). I've also added a bit of identation for
better layout test code readability. As for the non-accessible-file.txt
message, I needed a text file that could present a FAIL message if file could
still be accessible even after the LocalContentCanAccessFileUrls is set to
false. There is a similar text file (
LayoutTests/fast/loader/resources/plain-text-document.txt ) that does exactly
the opposite (contains a PASS message if content is readable) used by another
test, so I guess it is fine to use it as it is.


More information about the webkit-reviews mailing list